fix(core/Canvas): explicitly enable autoFocus #956
Merged
+255
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll otherwise break embedding with existing applications, cf. bpmn-io/bpmn-js-examples#302.
nikku
force-pushed
the
optional-autofocus
branch
from
d06b3cd to
6f8ce2e
Compare
Ensure we update focus related behaviors consistently on manual and DOM triggered interactions.
If canvas for whatever reason is not focused, then movement does not happen. Related to #662
nikku
force-pushed
the
optional-autofocus
branch
from
6f8ce2e to
52725d4
Compare
4 tasks
|
Cf. bpmn-io/bpmn-js-examples#302 (comment) how this pans out in a real embedding scenario. |
barmac
approved these changes
Dec 20, 2024
|
I think this is a great improvement which complements the keyboard binding changes. We shipped a slightly broken behavior in 15, and now fix it, so no breaking change. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This ensures we're NOT automatically auto-focusing the canvas on any hover. Instead integrators must explicitly decide if this is desired, i.e. because the diagram is embedded as a "full page editor". We'll otherwise break embedding with existing applications, cf. bpmn-io/bpmn-js-examples#302.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}